Code

Apple Network Framework SecItem#668

Code

Open

sbSteveK wants to merge 174 commits intonw_socketawslabs/aws-c-io:nw_socketfrom nw_secitemawslabs/aws-c-io:nw_secitemCopy head branch name to clipboard

+1,822-234

Commits

Commits on Aug 21, 2024

• initial secitem implementation for iOS

  sbSteveK

  committed
  92e2bf3

• nw_parameters_create_custom_ip not available on iOS

  sbSteveK

  committed
  cad8639

Commits on Sep 3, 2024

• add Network Socket related TLS error codes

  sbSteveK

  committed
  e0a5f59

• work in progress setting up identity for use during nw connection

  sbSteveK

  committed
  ac6390e

• Merge branch 'nw_socket' into nw_secitem

  sbSteveK

  committed
  8b47db8

• setting setup_run to true has to occur before submitting result to prevent accessing cleared nw_socket

  sbSteveK

  committed
  1246540

Commits on Sep 5, 2024

• Checkpoint before PKCS12

  sbSteveK

  committed
  c97a0f1

Commits on Sep 9, 2024

• add pkcs12 import

  sbSteveK

  committed
  82f399b

• use mutable dictionaries

  sbSteveK

  committed
  fd81c00

• pass error as pointer

  sbSteveK

  committed
  d09df65

Commits on Sep 17, 2024

• root_ca and verification block

  sbSteveK

  committed
  1edfe43

Commits on Sep 18, 2024

• merge with latest nw_socket changes

  sbSteveK

  committed
  4aa7590

• remove TLS slot creation for iOS as it's handled internally by nw_connection

  sbSteveK

  committed
  4b8b2a4

• clarity related name changes

  sbSteveK

  committed
  6984b79

Commits on Sep 19, 2024

• merge with changes to nw_socket_2

  sbSteveK

  committed
  8ba6827

Commits on Sep 20, 2024

• pass host name and tls ctx to nw_connection parameter initialization

  sbSteveK

  committed
  de92f24

• unify root ca handling for macOS and iOS

  sbSteveK

  committed
  32f4af5

• minor cleanup of darwin_pki_utils.c

  sbSteveK

  committed
  df152fa

Commits on Sep 23, 2024

• private header for dispatch queue and use of dispatch queue in verification block

  sbSteveK

  committed
  cd84db5

• group TLS errors

  sbSteveK

  committed
  3341c7c

• remove unecessary wrappers around CFRelease

  sbSteveK

  committed
  c6aa207

• remove CFRelease wrapping cont.

  sbSteveK

  committed
  6beed13

• remove some platform specific build items

  sbSteveK

  committed
  2ad7f1d

• move secure_transport_ctx to private header

  sbSteveK

  committed
  dc506e7

• remove unecessary include

  sbSteveK

  committed
  1745e21

• clarify comments

  sbSteveK

  committed
  8557fba

• remove print statements

  sbSteveK

  committed
  bfd662e

Commits on Sep 24, 2024

• check if nw_socket is open before trying to cancel/close

  sbSteveK

  committed
  d4959a6

• state change handler expansion

  sbSteveK

  committed
  c8e2a5e

• Merge branch 'nw_socket_2' into nw_secitem

  sbSteveK

  committed
  29d5b06

• check if closed and reorder socket close

  sbSteveK

  committed
  739140e

• Merge branch 'nw_socket_2' into nw_secitem

  sbSteveK

  committed
  fad7e91

• dispatch_queue.h

  sbSteveK

  committed
  beec73d

• merge nw_socket_2

  sbSteveK

  committed
  a4be446

• merge with nw_socket

  sbSteveK

  committed
  8945b5f

• merge with nw_socket

  sbSteveK

  committed
  8b3fad0

• Merge branch 'nw_socket' into nw_secitem

  sbSteveK

  committed
  63311b8

• Merge branch 'nw_socket' into nw_secitem

  sbSteveK

  committed
  da24afd

• Merge branch 'nw_socket' into nw_secitem

  sbSteveK

  committed
  fb8c0aa

• clang format

  sbSteveK

  committed
  1ff2443

• better comments and clearer action branching

  sbSteveK

  committed
  76d7368

Commits on Sep 26, 2024

• save copy of host_name to the nw_socket on connect

  sbSteveK

  committed
  aefa022

• use of aws_secitem_options

  sbSteveK

  committed
  06ff298

• updated tls options retreival at nw_socket connect

  sbSteveK

  committed
  c6adea9

• set min tls version

  sbSteveK

  committed
  2bcc063

• comment cleanup

  sbSteveK

  committed
  19e6055

Commits on Sep 27, 2024

• rename parameters and catch some potential mem leaks

  sbSteveK

  committed
  9acfc22

• handle default and invalid TLS protocol version

  sbSteveK

  committed
  fcbc2b6

• expand commenting

  sbSteveK

  committed
  16d498d

• seitem_options handling improved

  sbSteveK

  committed
  b047d2c

• handle default value that shouldn't be hit

  sbSteveK

  committed
  eec1b39

Commits on Sep 30, 2024

• space

  sbSteveK

  committed
  a58111a

Commits on Oct 1, 2024

• rename set secitem options argument for clarity

  sbSteveK

  committed
  3353ec6

• missed a spot

  sbSteveK

  committed
  209be07

Commits on Oct 2, 2024

• const the secitem options and improve logging

  sbSteveK

  committed
  ced9f88

• s_schedule_next_read should not return anything

  sbSteveK

  committed
  bdcbf39

• forgot ;

  sbSteveK

  committed
  b9e5411

• use define AWS_USE_SECITEM instead of AWS_OS_IOS

  sbSteveK

  committed
  2f5d2ce

• some aspects should still do an ios check

  sbSteveK

  committed
  c3a6bd6

• change the ifdef to AWS_USE_DISPATCH_QUEUE in dispatch_queue.h

  sbSteveK

  committed
  b7e75a9

Commits on Oct 3, 2024

• ifdef checks for AWS_USE_DISPATCH_QUEUE

  sbSteveK

  committed
  849d009

• forward declare aws_tls_connection_options

  sbSteveK

  committed
  a3a7a6c

• split out the ifndefs

  sbSteveK

  committed
  c9c6600

• if -> ifdef

  sbSteveK

  committed
  6113acf

• if -> ifdef

  sbSteveK

  committed
  99e1ed0

• merge with latest nw_socket

  sbSteveK

  committed
  f75ffc4

• apply platform check where applicable

  sbSteveK

  committed
  968edde

Commits on Oct 4, 2024

• all apple builds need secure_transport_ctx

  sbSteveK

  committed
  e102c32

• aws-c-io platform.h should include aws-c-common platform.h to setup OS

  sbSteveK

  committed
  cde0b76

• fix unused error

  sbSteveK

  committed
  4363d64

• remove platform.h and rename dispatch_queue.h

  sbSteveK

  committed
  3caac5e

• merge with latest nw_socket

  sbSteveK

  committed
  f165dfe

• aws_socket_connect fix in tests

  sbSteveK

  committed
  02deb47

• missed a connect

  sbSteveK

  committed
  01e4356

• clang format

  sbSteveK

  committed
  9082d44

• clang

  sbSteveK

  committed
  93c8a72

• fix windows/iocp definition s_socket_connect

  sbSteveK

  committed
  c6656e9

• wrap double defined socket functions in an ifdef check

  sbSteveK

  committed
  d895738

Commits on Oct 7, 2024

• rearranging

  sbSteveK

  committed
  95a7a8a

• merge with nw_socket

  sbSteveK

  committed
  8d353f1

• remove deprecated kSecTrustResultConfirm to string

  sbSteveK

  committed
  83c43de

• remove support for deprecated tls versions

  sbSteveK

  committed
  ad15ad2

• unused metadata (void)

  sbSteveK

  committed
  64cff09

• SecIdentityRef to sec_identity_t in secure_transport_ctx

  sbSteveK

  committed
  ef0f550

• remove unused parameter from s_setup_socket_params

  sbSteveK

  committed
  7ca4fbc

• remove unused socket variable

  sbSteveK

  committed
  4572550

• replace deprecated verify block function

  sbSteveK

  committed
  2861462

• error used before initialized

  sbSteveK

  committed
  ca52061

• try dispatch queue with secitem

  sbSteveK

  committed
  10032ad

Commits on Oct 8, 2024

• use the correct matrix for macos job

  sbSteveK

  committed
  e7cd42e

Commits on Oct 15, 2024

• merge with nw_socket_udp changes

  sbSteveK

  committed
  c859bde

• event_loop handling in nw_socket

  sbSteveK

  committed
  efde266

• fix test

  sbSteveK

  committed
  c9ddf44

Commits on Oct 16, 2024

• fix wrong name in AWS_PRECONDITION func check

  sbSteveK

  committed
  ade496f

• add checks for nw_parameters and return errors if missing

  sbSteveK

  committed
  4f17063

• handle missing tls_options

  sbSteveK

  committed
  b68abcf

• setup proper parameters for a local socket

  sbSteveK

  committed
  521294c

Commits on Oct 17, 2024

• add Secitem option to build

  sbSteveK

  committed
  79e28bb

• merge with latest nw_socket

  sbSteveK

  committed
  f064f21

• endif

  sbSteveK

  committed
  c0ea8ec

• missing function from merge

  sbSteveK

  committed
  c153294

• merge changes

  sbSteveK

  committed
  2e681df

• try including aws_apple_network_framework despite not ifndef dispatch

  sbSteveK

  committed
  f2fd4cd

• try to turn on secitem testing

  sbSteveK

  committed
  9bde1ae

• super clarify AWS_USE_SECITEM

  sbSteveK

  committed
  303bb92

• separate out secitem CI job

  sbSteveK

  committed
  af0b484

• Fix CMakeLists for secitem

  sbSteveK

  committed
  618ec16

• CMakeLists.txt revision

  sbSteveK

  committed
  ecf722b

• test

  sbSteveK

  committed
  d001e8e

Commits on Oct 18, 2024

• CMakeLists changes

  sbSteveK

  committed
  aeb4cb7

• fully separate out secitem in cmakelists

  sbSteveK

  committed
  c6c03ec

• add separated cmake-extra

  sbSteveK

  committed
  12e4669

• temp have TLS errors all return a singular error

  sbSteveK

  committed
  27dae96

Commits on Oct 24, 2024

• cleaner passing of tls related pointers and initial tls_result handling for nw_socket

  sbSteveK

  committed
  622fc7c

• zero struct properly

  sbSteveK

  committed
  3d8d019

• restore granular TLS errors and include an error check for TLS errors

  sbSteveK

  committed
  fab363d

• store and serve tls error hotfix

  sbSteveK

  committed
  c9c072a

• add errSSLPeerProtocolVersion error case as TLS negotiation error

  sbSteveK

  committed
  63bb48b

Commits on Oct 25, 2024

• rename nw_socket tasks and fix peer_verification skip

  sbSteveK

  committed
  8ffbc9e

• try removing test that Secitem doesn't support

  sbSteveK

  committed
  cff20a6

• rename socket timeout cancellation task

  sbSteveK

  committed
  54fd3ff

• remove tests for SECITEM that require an appbundle and entitlements

  sbSteveK

  committed
  f93cb36

• more descriptive verification error reporting

  sbSteveK

  committed
  d4c3a2c

• actually set min tls version to 1.1 in test

  sbSteveK

  committed
  a43174e

• fix setting of proper requested tls version on tests

  sbSteveK

  committed
  c0be01e

Commits on Oct 28, 2024

• revert tls version tests

  sbSteveK

  committed
  e0af474

• missed a TLS revert

  sbSteveK

  committed
  9c096a5

• another missed revert

  sbSteveK

  committed
  187b704

• WIP checkpoint

  sbSteveK

  committed
  2b9a972

• Merge branch 'nw_socket' into nw_secitem

  sbSteveK

  committed
  81288f5

• comment out unused test func

  sbSteveK

  committed
  fc93da9

• match server and client setup complete callback logic

  sbSteveK

  committed
  1398249

Commits on Oct 29, 2024

• pkcs8 not supported on iOS

  sbSteveK

  committed
  851273d

• misspelling

  sbSteveK

  committed
  ecc4417

Commits on Oct 31, 2024

• logic on setup_completed related to secitem/tls separation

  sbSteveK

  committed
  03f67bc

• set protocol server name in parameters

  sbSteveK

  committed
  c519e19

• temp pass as successful socket slot only

  sbSteveK

  committed
  9df47da

• reorganize handling of secitem setup completed

  sbSteveK

  committed
  a81b09b

Commits on Nov 1, 2024

• add alpn protocols to parameters

  sbSteveK

  committed
  3de0e84

Commits on Nov 4, 2024

• add to socket vtable to allow access to protocol and server_name

  sbSteveK

  committed
  a1226e9

• missed a ;

  sbSteveK

  committed
  8e735cf

• set new vtable functions in non secitem sockets to null

  sbSteveK

  committed
  5ae660d

• log errors when secitem functions are called on non-secitem sockets

  sbSteveK

  committed
  c6869e4

• trigger negotiation result using secitem

  sbSteveK

  committed
  36e5c73

• check for NULL before releasing verification CF objects

  sbSteveK

  committed
  1ff72ae

• remove unused callback from nw_socket and add null terminator to protocol buf

  sbSteveK

  committed
  b586a9e

• move around some declarations

  sbSteveK

  committed
  5030dee

• secitem allows import of cert/key

  sbSteveK

  committed
  7cf8376

• another test that requires entitlements

  sbSteveK

  committed
  4e45818

Commits on Nov 5, 2024

• split out the tls block of parameters

  sbSteveK

  committed
  df15054

• s_setup_tls_options needs to be wrapped in ifdef Secitem

  sbSteveK

  committed
  649d554

• simplify parameters logic

  sbSteveK

  committed
  b3b6645

• SecItem does not use tls channel statistics

  sbSteveK

  committed
  b7882f9

• allow passing of an event loop into a server listener bind

  sbSteveK

  committed
  e875822

• forgot iocp socket_bind

  sbSteveK

  committed
  8674aa7

• missed it

  sbSteveK

  committed
  1efece0

• cleanup and test fix for windows

  sbSteveK

  committed
  e66a9a6

Commits on Nov 6, 2024

• restore s2n in cmakelists

  sbSteveK

  committed
  6836232

• aws_apple_network_framework.h should only be used with Apple OS

  sbSteveK

  committed
  b4c9306

• documentation

  sbSteveK

  committed
  79ba389

Commits on Nov 7, 2024

• more documentation and logic simplification

  sbSteveK

  committed
  32ea35d

• cleanup

  sbSteveK

  committed
  0ba007b

• simplify tls error_code reporting in channel bootstrap

  sbSteveK

  committed
  565de94

• documentation and reorder

  sbSteveK

  committed
  b7b96ca

Commits on Nov 8, 2024

• documentation and cleanup

  sbSteveK

  committed
  31eab1e

• unify tls options from context

  sbSteveK

  committed
  bf4680a

• remove unecessary check

  sbSteveK

  committed
  bd6d2da

• wrap secitem function execution within a block to maintin min macOS version during builds

  sbSteveK

  committed
  5e95bbb

Commits on Nov 13, 2024

• initial merge with latest nw_socket

  sbSteveK

  committed
  41923c1

• definition misspelling

  sbSteveK

  committed
  14a79cc

Commits on Dec 4, 2024

• merge with latest nw_socket

  sbSteveK

  committed
  8daedcb

• include private socket header for secure_transport_tls_channel_handler.c

  sbSteveK

  committed
  aa21e8b

• handle duplicate functions related to darwin

  sbSteveK

  committed
  5c211f1

• wrong define label

  sbSteveK

  committed
  fd147d1