Grand dispatch queue #661
Open
Grand dispatch queue #661
+811
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## runtime_select_event_loop #661 +/- ##
=============================================================
- Coverage 79.66% 79.65% -0.01%
=============================================================
Files 30 30
Lines 6121 6123 +2
=============================================================
+ Hits 4876 4877 +1
- Misses 1245 1246 +1 ☔ View full report in Codecov by Sentry. |
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
…io into grand_dispatch_queue
bretambrose
reviewed
Nov 13, 2024
…io into grand_dispatch_queue
…io into grand_dispatch_queue
bretambrose
reviewed
Dec 3, 2024
| struct aws_string *dispatch_queue_id; | ||
|
|
||
| /* Synced data handle cross thread tasks and events, and event loop operations*/ | ||
| struct { |
There was a problem hiding this comment.
Why is this block separate from synced_thread_data? Does the lock in synced_thread_data guard this too? I would not split them like this
| } | ||
|
|
||
| // Iteration function that scheduled and executed by the Dispatch Queue API | ||
| static void s_run_iteration(void *context) { |
There was a problem hiding this comment.
The locking here seems a little unnecessarily complex. If you look at a single call to s_run_iteration:
lock(context)
unlock(context)
lock(context) // via begin_iteration, also this seems wrong as you're slurping cross-thread tasks which should be protected by lock(loop) instead
unlock(context) // via begin_iteration
lock(loop)
set thread id/execution
unlock(loop)
run all tasks
lock(loop)
executing = false
unlock(loop)
lock(context) // via end_iteration, again this appears wrong since you access lock(loop) protected data here
unlock(context)
…io into grand_dispatch_queue
sbSteveK
commented
Dec 4, 2024
…io into grand_dispatch_queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of Apple's grand dispatch queue with event loop
The CI is failing for dispatch queue because of the apple network socket is not in. The socket related changes is in PR: #662
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.