CMake package should add the modules to CMAKE_MODULE_PATH #587
Conversation
Right now aws-c-event-stream needs a lot of boilerplate code to determine the modules installation path while the aws-c-common package should provide it. This would fix awslabs/aws-c-event-stream#15 simply by moving `find_package(aws-c-common REQUIRED)` before the various module `include`s Using `configure_package_config_file` makes it easier to have a relocatable package.
`aws-c-event-stream` should not need to worry nor now how to find the `aws-c-common` CMake modules. This can be fixed by simply moving up `find_package(aws-c-common REQUIRED)` and making the `aws-c-common` package set the paths correctly. This has been confirmed to work on amazon linux 2. This commit requires awslabs/aws-c-common#587 to be merged first.
|
Any news on this ? |
|
I think this is a great change, but we'd need to apply it evenly across all the repos (there's 8 more), so it will take time. It's also a lot of work when we get the cmake stuff wrong to get them upgraded. We're evaluating this and we'll apply it next time we touch our cmake. As for the linked issue, it looks like your code is out of date. The actual bug was fixed a while ago. Are you having problems with the latest commit? |
Sorry I missed the question last time. Should I try with latest master ? |
Issue: awslabs/aws-c-event-stream#15
Right now
aws-c-event-streamneeds a lot of boilerplate code to determine the modules installation path while theaws-c-commonpackage should provide it.This would fix awslabs/aws-c-event-stream#15 simply by moving
find_package(aws-c-common REQUIRED)before the various moduleincludesUsing
configure_package_config_filemakes it easier to have a relocatable package.A pull request will be opened in
aws-c-event-streamtoo.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.