Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While reviewing PR #1170 (comment) (which fixed an invalid index warning in this test), I gave this test a good hard look, and realized it was broken. As I slowly made sense of this test, I found another way it was broken.
Research:
This hash table test was added with the original hash table PR #17.
That branch had 2 different authors, which seems to have led to the brokenness
entries[i -1]
checks that don't really make sense becauseentries
isn't sortedDescription of changes
sorted_entries
array instead of the unsortedentries
arrayBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.