-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward CMake variables to prebuilding dependencies #1161
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 57 57
Lines 5953 5953
=======================================
Hits 4979 4979
Misses 974 974 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good.
There might be a few more things we should look into (mentioned in comments), but when you're happy with it, I'm happy with it.
Issue #, if available:
When prebuilding dependencies, we need to pass certain CMake variables from parent cmake process to child cmake process (e.g. toolchain file or path to C compiler). CMake doesn't provide this functionality out of the box.
Description of changes:
This PR implements a new CMake function that checks CMake cache file and collects variables that may affect build process.
aws_prebuild_dependency
uses this new function, so no changes are required in the downstream projects.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.