Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmake Prebuild Remove -S Option #1158

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix Cmake Prebuild Remove -S Option #1158

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
996b001
remove -s
waahm7 Oct 16, 2024
e992ff8
Merge branch 'main' into fix-cmake-prebuild
waahm7 Oct 16, 2024
259a1b5
Update cmake/AwsPrebuildDependency.cmake
waahm7 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmake/AwsPrebuildDependency.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ function(aws_prebuild_dependency)
# Convert prefix path from list to escaped string, to be passed on command line
string(REPLACE ";" "\\\\;" ESCAPED_PREFIX_PATH "${CMAKE_PREFIX_PATH}")
# For execute_process to accept a dynamically constructed command, it should be passed in a list format.

waahm7 marked this conversation as resolved.
Show resolved Hide resolved
set(cmakeCommand "${CMAKE_COMMAND}")
list(APPEND cmakeCommand -S ${AWS_PREBUILD_SOURCE_DIR})
list(APPEND cmakeCommand ${AWS_PREBUILD_SOURCE_DIR})
list(APPEND cmakeCommand -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE})
list(APPEND cmakeCommand -DCMAKE_PREFIX_PATH=${ESCAPED_PREFIX_PATH})
list(APPEND cmakeCommand -DCMAKE_INSTALL_PREFIX=${depInstallDir})
Expand Down
Loading