Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s_has_vpclmulqdq fix #1087

Closed
wants to merge 1 commit into from
Closed

s_has_vpclmulqdq fix #1087

wants to merge 1 commit into from

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Feb 5, 2024

check correct bit for VPCLMULQDQ

Issue #, if available:
#1084

Description of changes:
s_has_vpclmulqdq() is not checking the co

rrect bit to detect VPCLMULQDQ.
According to the documentation it is bit 10. (code is checking bit 20).

Input Output
EAX=07H, ECX=0 ECX[bit 10] VPCLMULQDQ
EAX=07H, ECX=0 EBX[bit 16] AVX512F
EAX=07H, ECX=0 EBX[bit 31] AVX512VL

https://en.wikichip.org/wiki/x86/vpclmulqdq

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmklix
s_has_vpclmulqdq fix
d8a9d59 
check correct bit for VPCLMULQDQ
@jmklix jmklix linked an issue Feb 5, 2024 that may be closed by this pull request
s_has_vpclmulqdq() is not checking correct bit to detect VPCLMULQDQ #1084
Closed
@jmklix jmklix closed this Feb 5, 2024
@jmklix
Copy link
Member Author

jmklix commented Feb 5, 2024

this will be fixed in another PR

@jmklix jmklix deleted the s_has_vpclmulqdq_fix branch February 5, 2024 19:54
@jmklix jmklix removed a link to an issue Feb 22, 2024
s_has_vpclmulqdq() is not checking correct bit to detect VPCLMULQDQ #1084
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmklix