Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of libnuma.so #1068

Merged
merged 1 commit into from
Oct 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,15 +323,15 @@ void aws_common_library_init(struct aws_allocator *allocator) {
assumptions due to the way loaders and dlload are often implemented and those symbols are defined by things
like libpthread.so on some unix distros. Sorry about the memory usage here, but it's our only safe choice.
Also, please don't do numa configurations if memory is your economic bottleneck. */
g_libnuma_handle = dlopen("libnuma.so", RTLD_LOCAL);
g_libnuma_handle = dlopen("libnuma.so", RTLD_LAZY | RTLD_LOCAL);

/* turns out so versioning is really inconsistent these days */
if (!g_libnuma_handle) {
g_libnuma_handle = dlopen("libnuma.so.1", RTLD_LOCAL);
g_libnuma_handle = dlopen("libnuma.so.1", RTLD_LAZY | RTLD_LOCAL);
}

if (!g_libnuma_handle) {
g_libnuma_handle = dlopen("libnuma.so.2", RTLD_LOCAL);
g_libnuma_handle = dlopen("libnuma.so.2", RTLD_LAZY | RTLD_LOCAL);
}

if (g_libnuma_handle) {
Expand Down