-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic process mem usage functions #1065
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 82.69% 82.68% -0.02%
==========================================
Files 54 55 +1
Lines 5708 5716 +8
==========================================
+ Hits 4720 4726 +6
- Misses 988 990 +2
☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,30 @@ | |||
#ifndef AWS_COMMON_SYSTEM_RESOURCE_UTIL_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debatable: We already have a system_info header which might be a good place for these functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im on the fence about it. I was originally planning to put it into system_info, but functions here have a slightly different use case - how many resource is my process consuming vs which system im running on. I was also planning to add functions to modify resource limits to this file, which will diverge things even more in future. So im leaning towards a separate header.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.