Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic process mem usage functions #1065

Merged
merged 15 commits into from
Oct 23, 2023
Merged

Basic process mem usage functions #1065

merged 15 commits into from
Oct 23, 2023

Conversation

DmitriyMusatkin
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f705c61) 82.69% compared to head (31624a6) 82.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   82.69%   82.68%   -0.02%     
==========================================
  Files          54       55       +1     
  Lines        5708     5716       +8     
==========================================
+ Hits         4720     4726       +6     
- Misses        988      990       +2     
Files Coverage Δ
source/posix/system_resource_utils.c 87.50% <87.50%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

include/aws/common/system_resource_util.h Outdated Show resolved Hide resolved
@@ -0,0 +1,30 @@
#ifndef AWS_COMMON_SYSTEM_RESOURCE_UTIL_H
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debatable: We already have a system_info header which might be a good place for these functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im on the fence about it. I was originally planning to put it into system_info, but functions here have a slightly different use case - how many resource is my process consuming vs which system im running on. I was also planning to add functions to modify resource limits to this file, which will diverge things even more in future. So im leaning towards a separate header.

CMakeLists.txt Show resolved Hide resolved
tests/system_resource_util_test.c Outdated Show resolved Hide resolved
@DmitriyMusatkin DmitriyMusatkin merged commit f676897 into main Oct 23, 2023
51 checks passed
@DmitriyMusatkin DmitriyMusatkin deleted the rusage branch October 23, 2023 22:08
@DmitriyMusatkin DmitriyMusatkin restored the rusage branch October 23, 2023 22:39
@graebm graebm deleted the rusage branch October 24, 2023 23:33
@graebm graebm restored the rusage branch October 24, 2023 23:33
@DmitriyMusatkin DmitriyMusatkin deleted the rusage branch October 30, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants