-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an environment loader API and implementation for some DMI related fields #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng, added api for detecting virt vendor.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 82.73% 82.65% -0.09%
==========================================
Files 52 54 +2
Lines 5664 5707 +43
==========================================
+ Hits 4686 4717 +31
- Misses 978 990 +12
☔ View full report in Codecov by Sentry. |
graebm
reviewed
Oct 11, 2023
trivial PR merge. Co-authored-by: Michael Graeb <[email protected]>
…t (there wasn't one).
…'t waste 4KB on these short strings.
graebm
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an environment loading API as these probes are not cheap and this is my proposal for keeping it from getting to messy over time.
Long term I see this containing metadata about NIC configurations, cpu and gpu information, memory bus information, etc... Then other parts of the system can load the environment once to make optimization and defaulting decisions.
This is currently being used in aws-c-s3 for determining if we're running on ec2 nitro and figuring out the instance type. It's very much intended to contain more data over time as the configurations get more involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.