Report actual bytes leaked/Fix realloc tracing #1053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Report actual bytes leaked and not number of leaks as it says in the log message.
Fix the bug with memtracer keeping incorrect records for realloc.
Previous logic for tracking realloc usage was
Problem with that was that memtrace realloc was not thread safe as a whole. Ex. say thread 1 does a realloc operation, it calls parent realloc and then thread 2 takes control and realloc reuses address that thread 1 just released and clobbers the records for that address, so when thread 1 gets control back, record for the address will have changed and thread 1 will update tracking data incorrectly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.