dont need all those functions for an internal api.

awslabs · Oct 5, 2023 · 5c1917e · 5c1917e
1 parent 6a7c30c
commit 5c1917e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/include/aws/common/private/system_info_priv.h b/include/aws/common/private/system_info_priv.h
@@ -22,8 +22,4 @@ struct aws_system_environment {
 int aws_system_environment_load_platform_impl(struct aws_system_environment *env);
 void aws_system_environment_destroy_platform_impl(struct aws_system_environment *env);
 
-
-void aws_system_environment_load_virtualization_vendor_impl(struct aws_system_environment *env);
-void aws_system_environment_load_virtualization_product_name_impl(struct aws_system_environment *env);
-
 #endif /* AWS_COMMON_SYSTEM_INFO_PRIV_H */
diff --git a/source/linux/system_info.c b/source/linux/system_info.c
@@ -3,19 +3,14 @@
 #include <aws/common/file.h>
 
 int aws_system_environment_load_platform_impl(struct aws_system_environment *env) {
-    (void)env;
+    aws_byte_buf_init_from_file(&env->virtualization_vendor, env->allocator, "/sys/devices/virtual/dmi/id/sys_vendor");
+    aws_byte_buf_init_from_file(&env->product_name, env->allocator, "/sys/devices/virtual/dmi/id/product_name");
 
     return AWS_OP_SUCCESS;
 }
 
 void aws_system_environment_destroy_platform_impl(struct aws_system_environment *env) {
-    (void)env;
+    aws_byte_buf_clean_up(&env->virtualization_vendor);
+    aws_byte_buf_clean_up(&env->product_name);
 }
 
-void aws_system_environment_load_virtualization_vendor_impl(struct aws_system_environment *env) {
-    aws_byte_buf_init_from_file(&env->virtualization_vendor, env->allocator, "/sys/devices/virtual/dmi/id/sys_vendor");
-}
-
-void aws_system_environment_load_virtualization_product_name_impl(struct aws_system_environment *env) {
-    aws_byte_buf_init_from_file(&env->product_name, env->allocator, "/sys/devices/virtual/dmi/id/product_name");
-}
diff --git a/source/system_info.c b/source/system_info.c
@@ -12,9 +12,6 @@ struct aws_system_environment *aws_system_environment_load(struct aws_allocator
         goto error;
     }
 
-    aws_system_environment_load_virtualization_vendor_impl(env);
-    aws_system_environment_load_virtualization_product_name_impl(env);
-
     env->os = aws_get_platform_build_os();
     env->cpu_count = aws_system_info_processor_count();
     env->cpu_group_count = aws_get_cpu_group_count();