Even more pedantic clippy lints

awslabs · Dec 13, 2024 · 834ce2c · 834ce2c
1 parent 59802db
commit 834ce2c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/private/sources/policy/core.rs b/src/private/sources/policy/core.rs
@@ -398,7 +398,7 @@ pub mod test {
 
         let result = policy_source.fetch(policy_store_id).await.unwrap();
 
-        assert!(result.get(&policy_id_2).is_none());
+        assert!(!result.contains_key(&policy_id_2));
         assert_eq!(
             result.get(&policy_id_1).unwrap().clone(),
             Policy::try_from(static_definition).unwrap()

diff --git a/src/private/sources/template/core.rs b/src/private/sources/template/core.rs
@@ -281,7 +281,7 @@ pub mod test {
             .await
             .unwrap();
 
-        assert!(result.get(&policy_template_id_2).is_none());
+        assert!(!result.contains_key(&policy_template_id_2));
 
         let Template(template_result) = result.get(&policy_template_id).unwrap();
         let Template(template_copy) = Template::try_from(updated_output).unwrap();

diff --git a/src/private/types/policy_store_filter.rs b/src/private/types/policy_store_filter.rs
@@ -389,10 +389,10 @@ mod input {
         #[test]
         fn json_none() {
             let json = json!({});
-            let p: PolicyStoreFiltersInput =
+            let filters: PolicyStoreFiltersInput =
                 serde_json::from_value(json).expect("Unable to parse intended format");
             assert!(
-                matches!(p, PolicyStoreFiltersInput{principal:a,resource:b,policy_type:c,policy_template_id:d} if a.is_none() && b.is_none() && c.is_none() && d.is_none())
+                matches!(filters, PolicyStoreFiltersInput{principal,resource,policy_type,policy_template_id} if principal.is_none() && resource.is_none() && policy_type.is_none() && policy_template_id.is_none())
             );
         }
 
@@ -461,10 +461,10 @@ mod input {
         #[test]
         fn cli_none() {
             let cli = "";
-            let p: PolicyStoreFiltersInput =
+            let filters: PolicyStoreFiltersInput =
                 PolicyStoreFiltersInput::from_str(cli).expect("Unable to parse intended format");
             assert!(
-                matches!(p, PolicyStoreFiltersInput{principal:a,resource:b,policy_type:c,policy_template_id:d} if a.is_none() && b.is_none() && c.is_none() && d.is_none())
+                matches!(filters, PolicyStoreFiltersInput{principal,resource,policy_type,policy_template_id} if principal.is_none() && resource.is_none() && policy_type.is_none() && policy_template_id.is_none())
             );
         }
     }