Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CodeInterpreter support and AutoPrepare in AgentDefinitionB… #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrIce-9
Copy link

@MrIce-9 MrIce-9 commented Nov 28, 2024

…uilder

Issue #, if available: #24

Description of changes: Introduce CodeInterpreter support and AutoPrepare in AgentDefinitionBuilder

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

*/
public withCodeInterpreter() {
const codeInterpreterAction: bedrock.CfnAgent.AgentActionGroupProperty = {
actionGroupName: CODE_INTERPRETER_ACTION_NAME,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this as an optional input from the user. withCodeInterpreter(actionName: string)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is required or exactly what you mean. Is this a blocker?

lib/constructs/AgentDefinitionBuilder.ts Outdated Show resolved Hide resolved
Introduced skipResourceInUseCheckOnDelete in CodeInterpreter AG and forced the AG changes to be additive to do not override previous definitions
actionGroupName: CODE_INTERPRETER_ACTION_NAME,
actionGroupState: "ENABLED",
parentActionGroupSignature: CODE_INTERPRETER_PARENT_SIGNATURE,
skipResourceInUseCheckOnDelete: true,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added SkipresourceInUseCheckOnDelete as discussed offline out of the testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants