Create and Update Model Form #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/user-interface/react/package-lock.json
petermuller
approved these changes
Aug 28, 2024
| HealthCheckConfig: IContainerHealthCheckConfig; | ||
| Environment?: Record<string, string>[]; | ||
| }; | ||
|
|
||
| export type IModel = { |
There was a problem hiding this comment.
I'll have to edit this in my PR, so don't worry about for now, but I'm also adding a "UniqueId" which is the UUID that comes from LiteLLM, which is how we'd eventually reference the model for modifications/mutations if we need to do anything from the LiteLLM perspective.
| LoadBalancerConfig: ILoadBalancerConfig; | ||
| }; | ||
|
|
||
| export type IModelRequest = { |
There was a problem hiding this comment.
No action to take, but also to note (primarily for myself), this will need to have the ModelUrl added as a potential field as well. In the case that we add something directly to LiteLLM and don't create the infrastructure for it, we'd need the ability to set the model URI too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding the ability for users to create/update models via the LISA app if they are admins. A quick demo of the form can be seen below. Note: there are still placeholder descriptions in some places.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.