Feature/rag list api #215
Merged
Feature/rag list api #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estohlmann
reviewed
Dec 18, 2024
| embeddings = _get_embeddings(model_name=collection_id, id_token=id_token) | ||
| vs = get_vector_store_client(repository_id, index=collection_id, embeddings=embeddings) | ||
|
|
||
| doc_search = vs.similarity_search( |
There was a problem hiding this comment.
Do we really want to do a similarity search here to list out just the documents that have been loaded?
There was a problem hiding this comment.
This should have been removed. Good catch.
estohlmann
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding RAG List/Delete APIs
The addition of the following APIs will allow a user to list documents for a given repository and collection, as well as delete a select document in the collection. Deleting a document will delete all chunked parts of the original document from the collection.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.