Closing file context manager if upload is success #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedanley
reviewed
Dec 3, 2024
| @@ -434,7 +434,7 @@ export default function Chat ({ sessionId }) { | |||
| new LisaChatMessage({ | |||
| type: 'ai', | |||
| content: result, | |||
| metadata: metadata, | |||
| metadata: useRag ? { ...metadata, ...prev.history[prev.history.length - 1].metadata } : metadata, | |||
There was a problem hiding this comment.
Are we handling an empty history array?
There was a problem hiding this comment.
It won't be empty is RAG is used because when we get the context back it sets a chat history message already
There was a problem hiding this comment.
…if we're already talking about this line it might be cleaner to use prev.history.slice(-1)[0].metadata? I already approved so not blocking at all…more of a preference.
There was a problem hiding this comment.
Honestly looking at this code today, it all needs to be re-written, it is pretty nasty. Let's make note of this and I will get a task written to do some cleanup around this chat piece.
dustins
approved these changes
Dec 3, 2024
bedanley
approved these changes
Dec 3, 2024
estohlmann
deleted the
feature/close-file-context-if-upload-is-success
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the file context manager if file ingestion/upload is successful
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.