Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split textgen and embedding models in UI #19

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

estohlmann
Copy link
Member

Description of changes:

  • Updated UI to pull Models from config vs API, this allows us to get supplemental info
  • UI now only separates textgen vs embedding models in dropdowns, also only enables streaming for models that support it
  • Fixed longstanding bug where switching to a model with streaming active to a model that doesn't support streaming "locks" streaming as enabled

demo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@estohlmann
Copy link
Member Author

update to call the describe API and uses the results to map against the config. I was a little forward looking with my approach and this accounts for the following:

  • If a model is returned in the API that isn't in the config it will add it to both drop-downs and allow streaming to be toggled on
  • If a model isn't returned that IS listed in the config, it will NOT show up in the dropdowns

@estohlmann estohlmann merged commit bb0d1de into main Jun 5, 2024
2 checks passed
@estohlmann estohlmann deleted the feature/update-ui-to-split-models branch June 5, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants