Feature/in app config management #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedanley
reviewed
Nov 1, 2024
lib/user-interface/react/src/shared/modal/confirmation-modal.tsx
Outdated
Show resolved
Hide resolved
bedanley
reviewed
Nov 1, 2024
| @@ -105,12 +105,12 @@ describe.each(regions)('Chat Nag Pack Tests | Region Test: %s', (awsRegion) => { | |||
| //TODO Update expect values to remediate CDK NAG findings and remove debug | |||
| test('AwsSolutions CDK NAG Warnings', () => { | |||
| const warnings = Annotations.fromStack(stack).findWarning('*', Match.stringLikeRegexp('AwsSolutions-.*')); | |||
| expect(warnings.length).toBe(1); | |||
| expect(warnings.length).toBe(2); | |||
There was a problem hiding this comment.
Take a quick pass to see if we can knock out any of these nag findings with the newly created table.
bedanley
previously approved these changes
Nov 1, 2024
…' into feature/in-app-config-management
dustins
approved these changes
Nov 5, 2024
bedanley
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability for administrators to configure system banner settings and which components of the chat UI are enabled for all users.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.