Updates to address some cdk-nag warnings #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added dlq for lambdas w/enforced ssl - added limits for lambda concurrency
dustins
commented
Oct 28, 2024
| @@ -120,6 +120,6 @@ describe.each(regions)('Chat Nag Pack Tests | Region Test: %s', (awsRegion) => { | |||
|
|
|||
| test('NIST800.53r5 CDK NAG Errors', () => { | |||
| const errors = Annotations.fromStack(stack).findError('*', Match.stringLikeRegexp('NIST.*')); | |||
| expect(errors.length).toBe(14); | |||
| expect(errors.length).toBe(4); | |||
There was a problem hiding this comment.
changed due to reduced nag warnings
dustins
commented
Oct 28, 2024
| @@ -112,6 +112,6 @@ describe.each(regions)('API Core Nag Pack Tests | Region Test: %s', (awsRegion) | |||
|
|
|||
| test('NIST800.53r5 CDK NAG Errors', () => { | |||
| const errors = Annotations.fromStack(stack).findError('*', Match.stringLikeRegexp('NIST.*')); | |||
| expect(errors.length).toBe(7); | |||
| expect(errors.length).toBe(5); | |||
There was a problem hiding this comment.
changed due to reduced nag warnings
estohlmann
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses lowest hanging fruit for CDK nag warnings. Reduces nags to 299 from 355.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.