Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "path" component of the ContainerConfig object was redundant and unnecessarily complicated for customers to use. Historically, it referred to the path location of Dockerfiles from the root of the repo to where the model definitions were, but since we add customization on top of containers, we end up requiring that the paths are used. We specify in another option whether the model is using TGI/TEI/vLLM, and for all of these, there's a 1:1 match for it and its corresponding "path" option. The container spinup will fail if these don't match.
As part of the 3.0 release, the path changed even further to be relative to a folder inside of the root, which made it difficult to document and describe how to use it. This change removes it altogether and instead requires the backend to know where the files are, simplifying the request for customers, and preventing them from making more mistakes when creating a new LISA-hosted model.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.