Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "path" from API model #142

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

petermuller
Copy link
Contributor

The "path" component of the ContainerConfig object was redundant and unnecessarily complicated for customers to use. Historically, it referred to the path location of Dockerfiles from the root of the repo to where the model definitions were, but since we add customization on top of containers, we end up requiring that the paths are used. We specify in another option whether the model is using TGI/TEI/vLLM, and for all of these, there's a 1:1 match for it and its corresponding "path" option. The container spinup will fail if these don't match.

As part of the 3.0 release, the path changed even further to be relative to a folder inside of the root, which made it difficult to document and describe how to use it. This change removes it altogether and instead requires the backend to know where the files are, simplifying the request for customers, and preventing them from making more mistakes when creating a new LISA-hosted model.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@petermuller petermuller requested a review from estohlmann October 9, 2024 23:02
@petermuller petermuller self-assigned this Oct 9, 2024
Copy link
Contributor Author

@petermuller petermuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review a PR that I created, but Evan your changes look fine to me 👍

@estohlmann estohlmann merged commit 74b1e0f into develop Oct 9, 2024
4 checks passed
@estohlmann estohlmann deleted the feature/remove-path-param-for-BE-mapping branch October 9, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants