Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/prefix name clash #118

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Bug/prefix name clash #118

merged 9 commits into from
Sep 30, 2024

Conversation

estohlmann
Copy link
Member

Issue #, if available:

Description of changes:

Fixing an issue where adding role prefixes would cause LISA to not deploy. Also limiting the prefix fields to 20 characters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@estohlmann estohlmann marked this pull request as draft September 27, 2024 07:00
dustins
dustins previously approved these changes Sep 27, 2024
@estohlmann estohlmann marked this pull request as ready for review September 27, 2024 16:48
petermuller
petermuller previously approved these changes Sep 27, 2024
@petermuller
Copy link
Contributor

Nice! We can close out #92 with this set of changes too. Thanks for taking care of the python thing in here too

petermuller
petermuller previously approved these changes Sep 27, 2024
petermuller
petermuller previously approved these changes Sep 30, 2024
Copy link
Contributor

@petermuller petermuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicky comments in my latest review, but not anything that is blocking.

lib/core/utils.ts Outdated Show resolved Hide resolved
lib/models/docker-image-builder.ts Show resolved Hide resolved
test/cdk/stacks/chat.test.ts Show resolved Hide resolved
@estohlmann estohlmann merged commit 36264e9 into develop Sep 30, 2024
4 checks passed
@estohlmann estohlmann deleted the bug/prefix-name-clash branch October 1, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants