-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoints2.0 middleware and param binding generation. #430
Conversation
* | ||
* @param writer Settings used to generate. | ||
*/ | ||
default void renderEndpointBuiltInField(GoWriter writer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It might be better to collapse these into one method that returns a type responsible for these different things.
e.g.
default void endpointBuiltinHandler(): EndpointBuiltInHandler
interface EndpointBuiltInHandler {
default void renderEndpointBuiltInField(GoWriter writer) { }
default void renderEndpointBuiltInInvocation(GoWriter writer) {}
default void renderEndpointBuiltInInitialization(GoWriter writer, Parameters parameters) { }
}
Grouping these things together reduces the API surface of GoIntegration
, it also helps in finding all the various methods that may need overridden for related functionality.
All endpoints2.0 middleware and parameter binding generation lives here, while hooks were added for builtin generation on consumer SDKs