Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang builder image for iptables minimal base image #1571

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

vineeth-bandi
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Dec 9, 2024
@vineeth-bandi
Copy link
Member Author

Seems we are ok to override this based on previous changes: #885

/override eks-distro-base-tooling-presubmits-kind-al-2 eks-distro-base-tooling-presubmits-kind-al-2022

@vineeth-bandi
Copy link
Member Author

/override eks-distro-base-tooling-presubmits-kind-al-2

@eks-distro-bot
Copy link
Collaborator

@vineeth-bandi: Overrode contexts on behalf of vineeth-bandi: eks-distro-base-tooling-presubmits-kind-al-2

In response to this:

/override eks-distro-base-tooling-presubmits-kind-al-2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vineeth-bandi
Copy link
Member Author

/override eks-distro-base-tooling-presubmits-kind-al-2023

@eks-distro-bot
Copy link
Collaborator

@vineeth-bandi: Overrode contexts on behalf of vineeth-bandi: eks-distro-base-tooling-presubmits-kind-al-2023

In response to this:

/override eks-distro-base-tooling-presubmits-kind-al-2023

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aws aws deleted a comment from eks-distro-bot Dec 9, 2024
@aws aws deleted a comment from eks-distro-bot Dec 9, 2024
@aws aws deleted a comment from eks-distro-bot Dec 9, 2024
@markapruett
Copy link
Member

/lgtm

@vineeth-bandi
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vineeth-bandi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vineeth-bandi vineeth-bandi merged commit 6fea006 into aws:main Dec 9, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm minimal-image Changes related to the minimal-images or tooling size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants