Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark --eksGoReleases required for eksGoRelease #1389

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

wongma7
Copy link
Member

@wongma7 wongma7 commented Apr 4, 2024

Issue #, if available: n/a

Description of changes: it is required for each command, require it instead of silently exiting when it is not provided

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcrozean
Copy link
Member

rcrozean commented Apr 4, 2024

/lgtm

@wongma7
Copy link
Member Author

wongma7 commented Apr 4, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rcrozean
Copy link
Member

rcrozean commented Apr 4, 2024

/lgtm

@eks-distro-bot eks-distro-bot merged commit 377f2ca into aws:main Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants