Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch eks go readme update to occur on release #1281

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rcrozean
Copy link
Member

@rcrozean rcrozean commented Dec 11, 2023

Issue #, if available:

Description of changes:
When using the eksGoRelease commands, readme update makes more sense when officially releasing the new version rather than adding the patches and other changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcrozean rcrozean changed the title Switch readme update to occur on release Switch eks go readme update to occur on release Dec 12, 2023
@xdu31
Copy link
Member

xdu31 commented Dec 12, 2023

/lgtm

@xdu31
Copy link
Member

xdu31 commented Dec 12, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xdu31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 96bbef9 into aws:main Dec 12, 2023
6 checks passed
@rcrozean rcrozean deleted the updateEKSGoReleaseCommands branch April 9, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants