-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signature-v4-multi-region): add support for sigv4a package #6267
Draft
siddsriv
wants to merge
15
commits into
aws:main
Choose a base branch
from
siddsriv:sid/feat/sigv4a
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4a package in deps
d3808cd
to
6ee80ba
Compare
6ee80ba
to
c4f2e54
Compare
a908d87
to
b4f86d9
Compare
kuhe
reviewed
Jul 12, 2024
packages/signature-v4-multi-region/src/SignatureV4MultiRegion.spec.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Jul 12, 2024
packages/signature-v4-multi-region/src/SignatureV4MultiRegion.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Jul 12, 2024
packages/signature-v4-multi-region/src/SignatureV4MultiRegion.ts
Outdated
Show resolved
Hide resolved
09316af
to
655ddba
Compare
Do we have any idea when this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5146
Description
Add support in
signature-v4-multi-region
for the@smithy/signature-v4a
package.Partner PR: smithy-lang/smithy-typescript#1319
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.