Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add API Gateway #31954

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(pipes-targets): add API Gateway #31954

wants to merge 11 commits into from

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 30, 2024 •
edited
Loading

Add API Gateway REST API as a Pipes target.

Original PR with community review from @nmussy: #30772

@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2024 22:54
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Oct 30, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2024
@msambol
Copy link
Contributor Author

msambol commented Oct 30, 2024 •
edited
Loading

@Leo10Gama Got another one for you :) This was first reviewed in #30772, but was closed because of inactivity/merge conflicts.

@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4709a1c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Closed
@Leo10Gama Leo10Gama self-assigned this Nov 6, 2024
Leo10Gama
Leo10Gama reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Because of some of the policy permissions, I'm adding in the needs-security-review label as well, and review with security to verify the changes are OK. Other than that, one comment about how we're verifying the integ test.

packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts Show resolved Hide resolved
@Leo10Gama Leo10Gama added the needs-security-review Related to feature or issues that needs security review label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo10Gama Leo10Gama Leo10Gama left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Leo10Gama Leo10Gama

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK needs-security-review Related to feature or issues that needs security review p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msambol @aws-cdk-automation @Leo10Gama