Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): support emailVerified for AttributeMapping interface #31632

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yasuaki640
Copy link
Contributor

@yasuaki640 yasuaki640 commented Oct 3, 2024

Issue #30467

Closes #30467

Reason for this change

For custom OpenId providers, there is no way to automatically validate email upon sign-in.
Therefore, we would like to add the email_verified attribute to attribute mapping, but it is not present in the member definition of AttributeMapping interface., so we have added it in this PR.

Description of changes

Added emailVerified attribute to AttributeMapping interface.

Description of how you validated changes

Added the email_verified assertion to both unit and integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2024 12:01
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Oct 3, 2024
@yasuaki640 yasuaki640 changed the title feat(cognito): support emailVerified attribute mapping feat(cognito): support emailVerified for AttributeMapping interface Oct 3, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a03a9ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cognito: UserPoolIdentityProviderOidc does not support email_verified as attributeMapping
2 participants