chore(kinesisfirehose-alpha): replacedestinations property with destination and change type from array to single IDestination
#31630
+32
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype from array to single IDestination
paulhcsun
changed the title
paulhcsun
changed the title
destinations property type from array to single IDestination
aws-cdk-automation
previously requested changes
Oct 2, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
paulhcsun
changed the title
destinations property type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
paulhcsun
changed the title
destinations property with destination and change type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
paulhcsun
changed the title
destinations property with destination and change type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Setting a destination for your Delivery Stream was previously done by passing in an array of Destinations but with a restriction that there there could only be one Destination in that array. This property type does not make sense for the current user experience (have an array but can only specify one destination) and also does not align with the behaviour in the AWS Console which only allows you to select a single destination.
If Kinesis Firehose ever supports multiple destinations in the future then we can add a new property to support that which will not be a breaking change.
Description of changes
BREAKING CHANGE: replaced
destinationsproperty withdestination(singular) and changed the type from array of Destinations to a single Destination. Old behaviour would only allow an array with a single Destination to be passed in anyway.Description of how you validated changes
unit tests + no integ snapshot changes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license