-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): credentials system uses AWS SDK v3 #31572
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Changes (for now)
cdk-credential-provider
(provisional name), that serves as an API contract for plugin writers.CdkCredentials
, that replacesAWS.Credentials
. The new type is backwards compatible.--proxy
command line option. It is just ignored right now.PatchedSharedIniFileCredentials
. AWS SDK v3 now supports both use cases that motivated the creation of this class:credential_source
configuration option, and SSO profiles when reading from a shared credentials file.Ec2InstanceMetadata.refresh()
was being called. Since v3 does things differently, I created a fake metadata service, similar to the Fake STS.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license