-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fsx): specify file system type version for the Lustre file system #31136
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
**Note**: The `fileSystemTypeVersion` has a restrictions on the values that can be set based on the `deploymentType`. | ||
|
||
- `V_2_10` is supported by the Scratch and `PERSISTENT_1` deployment types. | ||
- `V_2_12` is supported by all Lustre deployment types, except for `PERSISTENT_2` with a metadata configuration mode. | ||
- `V_2_15` is supported by all Lustre deployment types and is recommended for all new file systems. | ||
|
||
**Note**: The default value of `fileSystemTypeVersion` is `V_2_10` except for the following cases: | ||
|
||
- Default value is `V_2_12` when `deploymentType` is set to `PERSISTENT_2` without a metadata configuration mode. | ||
- Default value is `V_2_15` when `deploymentType` is set to `PERSISTENT_2` with a metadata configuration mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have included descriptions related to metadata configuration mode, but the current LustreFileSystem
construct does not allow setting metadata. Should descriptions related to metadata be included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be good to either add a note stating that Metadata Configuration cannot be set yet, or alternatively, include the metadata configuration property in this PR.
What do you think?
The MetadataConfiguration property already exists, so it seems possible to add it. However, since it's a new property, it appears that descriptions haven't been defined for it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your opinion!
I think it is better to support MetadataConfiguration
initially, I was planning to address the metadataConfiguration
in this PR as well, but since all the CloudFormation documentation was marked as "not available," I decided to try again once that issue is resolved.
I have updated the README to reflect the assumption that metadataConfiguration
is not configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I've made some comments.
/** | ||
* The Lustre version for the file system. | ||
* | ||
* @see https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-fsx-filesystem.html#cfn-fsx-filesystem-filesystemtypeversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should remove ja_jp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've removed ja_JP/
**Note**: The `fileSystemTypeVersion` has a restrictions on the values that can be set based on the `deploymentType`. | ||
|
||
- `V_2_10` is supported by the Scratch and `PERSISTENT_1` deployment types. | ||
- `V_2_12` is supported by all Lustre deployment types, except for `PERSISTENT_2` with a metadata configuration mode. | ||
- `V_2_15` is supported by all Lustre deployment types and is recommended for all new file systems. | ||
|
||
**Note**: The default value of `fileSystemTypeVersion` is `V_2_10` except for the following cases: | ||
|
||
- Default value is `V_2_12` when `deploymentType` is set to `PERSISTENT_2` without a metadata configuration mode. | ||
- Default value is `V_2_15` when `deploymentType` is set to `PERSISTENT_2` with a metadata configuration mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be good to either add a note stating that Metadata Configuration cannot be set yet, or alternatively, include the metadata configuration property in this PR.
What do you think?
The MetadataConfiguration property already exists, so it seems possible to add it. However, since it's a new property, it appears that descriptions haven't been defined for it yet.
@mazyu36 Thank you for your review! I've addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
@mazyu36 Thanks! |
@pahud I'm sorry. This problem has resolved. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #31130
Reason for this change
We cannot specify Lustre version for the file system.
Description of changes
Add
fileSystemTypeVersion
prop toLustreFileSystemProps
.There are some restrictions about
fileSystemTypeVersion
.https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-fsx-filesystem.html#cfn-fsx-filesystem-filesystemtypeversion
I've only added validation of V2.10 is supported by the Scratch and Persistent_1 deployment types because
LustreFileSystemProps
does not have metadata configuration props.Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license