Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-targets): ecsTask uses invalid task definition arn in policy #30484

Closed
wants to merge 5 commits into from

Conversation

jwoehrle
Copy link
Contributor

@jwoehrle jwoehrle commented Jun 7, 2024

Issue # (if applicable)

Closes #30390

Reason for this change

Missing wildcard for imported task definition without revision in iam policystatement resource

Description of changes

In case of an imported task definition (ARN is not an unresolved Token) and there is no revision add :* to resource of policystatement

Description of how you validated changes

Added unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Jun 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 7, 2024 14:59
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jwoehrle jwoehrle changed the title chore: Add wildcard revision to imported taskdefinition. Fixes #30390 chore: add wildcard revision to imported taskdefinition. Fixes #30390 Jun 7, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 7, 2024 15:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 17, 2024
@paulhcsun paulhcsun changed the title chore: add wildcard revision to imported taskdefinition. Fixes #30390 fix(event-targets): add wildcard revision to imported taskdefinition. Fixes #30390 Jun 18, 2024
@paulhcsun
Copy link
Contributor

Hi @jwoehrle, thank you for the contribution! Would you be able to add some new integration tests and update the integration snapshots by running yarn integ --update-on-failed?

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 18, 2024
@paulhcsun paulhcsun changed the title fix(event-targets): add wildcard revision to imported taskdefinition. Fixes #30390 fix(event-targets): add wildcard revision to imported taskdefinition Jun 18, 2024
@paulhcsun paulhcsun changed the title fix(event-targets): add wildcard revision to imported taskdefinition fix(event-targets): ecsTask uses invalid task definition arn in policy Jun 18, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eba0eb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@jwoehrle
Copy link
Contributor Author

@paulhcsun
I'd be happy to add an integration test... However, I struggle with creating a TaskDefinition first and then later import it via the fromFargateTaskDefinitionAttributes. Can you point me into the right direction on how to basically deploy two stacks and use the string value of the arn of the first stack's TaskDefinition in the second stack? I need the actual string representation, not a CfnOutput which would be result in an Fn:ImportValue in the second stack

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 17, 2024
@paulhcsun paulhcsun reopened this Jul 25, 2024
@paulhcsun paulhcsun added the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Jul 25, 2024
@paulhcsun
Copy link
Contributor

hi @jwoehrle, apologies for the delay in my response, I've been out for the past couple weeks. You can create an integ test that contains two stacks and define resources separately for these stacks. I believe it is documented somewhere but I'm having some trouble finding it so I'll check with the team, however this integ test can be used as a reference for how to set that up: https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-with-replication.ts

Copy link
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark this pr to request changes as requested by @paulhcsun

@paulhcsun paulhcsun removed the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Sep 16, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
@samson-keung samson-keung reopened this Sep 27, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@samson-keung samson-keung removed the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Oct 1, 2024
@samson-keung samson-keung reopened this Oct 1, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@samson-keung
Copy link
Contributor

See new PR: #31615 that replaces this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(event-targets): EcsTask uses invalid task definition arn in policy
5 participants