Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in macro #355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dev-goyal
Copy link

@dev-goyal dev-goyal commented Mar 12, 2024

resolves #356

Description

Add the name of the catalog to the Iceberg CTE to prevent the error. This is already done for the drop table CTE, so I believe this was a bug.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dev-goyal dev-goyal marked this pull request as ready for review March 13, 2024 03:26
@moomindani moomindani added the enable-functional-tests This label enable functional tests label Mar 13, 2024
@moomindani
Copy link
Collaborator

The integration test failed. Could you please fix it?
https://github.com/aws-samples/dbt-glue/actions/runs/8262136038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests This label enable functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing catalog name in CTAS
2 participants