Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Remove unnecessary extra_py_files for Delta Lake #267

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

aajisaka
Copy link
Contributor

@aajisaka aajisaka commented Nov 10, 2023

Description

In the past, users had to configure extra_py_files to run Delta Python API. However, now it's no longer required because AWS Glue resolved the limitation.

Testing

Existing integration tests already cover this. There's no such configuration in the configuration for the integration tests https://github.com/aws-samples/dbt-glue/blob/main/tests/conftest.py

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@menuetb menuetb added the enable-functional-tests This label enable functional tests label Nov 10, 2023
@menuetb menuetb merged commit f5c40fc into aws-samples:main Nov 10, 2023
20 of 21 checks passed
@aajisaka aajisaka deleted the fix-delta-py-file branch November 10, 2023 11:41
@aajisaka
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests This label enable functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants