update dependencies of PyTorch base image #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeitaW
force-pushed
the
pytorch-container-update
branch
from
9cef2a2
to
74cbfd7
Compare
perifaws
reviewed
Aug 1, 2024
| export MAX_JOBS=32 && \ | ||
| export NVCC_PREPEND_FLAGS="-t 32" && \ | ||
| pip install -v -U git+https://github.com/facebookresearch/xformers.git@main#egg=xformers | ||
| #RUN export TORCH_CUDA_ARCH_LIST="8.0;9.0+PTX" && \ |
There was a problem hiding this comment.
remove unless there's a reason to keep
There was a problem hiding this comment.
makes sense. Removed in 6fcba53. Thank you!
| NVCC_GENCODE="-gencode=arch=compute_90,code=sm_90, -gencode=arch=compute_80,code=sm_80" \ | ||
| && rm -rf /tmp/nccl \ | ||
| && echo NCCL_SOCKET_IFNAME=^docker0,lo >> /etc/nccl.conf | ||
| #RUN apt-get remove -y libnccl2 libnccl-dev \ |
There was a problem hiding this comment.
remove if commented and no reason to keep
There was a problem hiding this comment.
I'd rather keep this as sometimes we want to install custom NCCL version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.