fix: display correct sm bandwidth in bytes/sec #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
previously approved these changes
Jun 26, 2024
jcosentino11
previously approved these changes
Jun 26, 2024
saranyailla
force-pushed
the
fix-bandwidth
branch
from
dc479fc
to
d7aac6f
Compare
jcosentino11
approved these changes
Jun 27, 2024
robcmann
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#41
Description of changes:
Console should display
STREAM_MANAGER_EXPORTER_MAX_BANDWIDTHprovided inkbpsin bytes/sec (Could be B/KB/MB/GB). Instead, the value is displayed inmbps. This PR fixes the conversion so the bandwidth is displayed in bytes/sec.Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.