-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use regional endpoints for large template uploads to S3 #539
Merged
ericzbeard
merged 1 commit into
aws-cloudformation:main
from
davidsuehring:fix-govcloud-changeset-uploads
Oct 2, 2024
Merged
Use regional endpoints for large template uploads to S3 #539
ericzbeard
merged 1 commit into
aws-cloudformation:main
from
davidsuehring:fix-govcloud-changeset-uploads
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericzbeard
approved these changes
Oct 2, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 16, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aws-cloudformation/rain](https://github.com/aws-cloudformation/rain) | minor | `v1.15.0` -> `v1.16.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aws-cloudformation/rain (aws-cloudformation/rain)</summary> ### [`v1.16.1`](https://github.com/aws-cloudformation/rain/releases/tag/v1.16.1) [Compare Source](aws-cloudformation/rain@v1.16.0...v1.16.1) This release features a set of new S3 Bucket Metadata commands that can be used to run scripts, upload content, and invalidate CloudFront distributions. The S3 directive also gets a new `Run` property that allows you to run build scripts for your lambda functions before uploading them. There is a fully functional serverless web application sample in `test/webapp` that demonstrates these new features. #### What's Changed - Adds Cross Compilation support for Linux ARM 64 by [@​georgealton](https://github.com/georgealton) in aws-cloudformation/rain#516 - Asset deployment and a sample web application by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#511 - Use regional endpoints for large template uploads to S3 by [@​davidsuehring](https://github.com/davidsuehring) in aws-cloudformation/rain#539 - Add Outputs to Pkl serialization, and fix formatting Pkl to Yaml with Pkl modules by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#540 - Fix skipping read only props by full path by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#541 - Version 1.16.0 by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#542 - Fixed release action #### Dependabot - Bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows by [@​dependabot](https://github.com/dependabot) in aws-cloudformation/rain#514 #### New Contributors - [@​georgealton](https://github.com/georgealton) made their first contribution in aws-cloudformation/rain#516 - [@​davidsuehring](https://github.com/davidsuehring) made their first contribution in aws-cloudformation/rain#539 **Full Changelog**: aws-cloudformation/rain@v1.15.0...v1.16.0 ### [`v1.16.0`](https://github.com/aws-cloudformation/rain/releases/tag/v1.16.0) [Compare Source](aws-cloudformation/rain@v1.15.0...v1.16.0) This release features a set of new S3 Bucket Metadata commands that can be used to run scripts, upload content, and invalidate CloudFront distributions. The S3 directive also gets a new `Run` property that allows you to run build scripts for your lambda functions before uploading them. There is a fully functional serverless web application sample in `test/webapp` that demonstrates these new features. #### What's Changed - Adds Cross Compilation support for Linux ARM 64 by [@​georgealton](https://github.com/georgealton) in aws-cloudformation/rain#516 - Asset deployment and a sample web application by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#511 - Use regional endpoints for large template uploads to S3 by [@​davidsuehring](https://github.com/davidsuehring) in aws-cloudformation/rain#539 - Add Outputs to Pkl serialization, and fix formatting Pkl to Yaml with Pkl modules by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#540 - Fix skipping read only props by full path by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#541 - Version 1.16.0 by [@​ericzbeard](https://github.com/ericzbeard) in aws-cloudformation/rain#542 #### Dependabot - Bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows by [@​dependabot](https://github.com/dependabot) in aws-cloudformation/rain#514 #### New Contributors - [@​georgealton](https://github.com/georgealton) made their first contribution in aws-cloudformation/rain#516 - [@​davidsuehring](https://github.com/davidsuehring) made their first contribution in aws-cloudformation/rain#539 **Full Changelog**: aws-cloudformation/rain@v1.15.0...v1.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #538
*Description of changes: Switch to using regional S3 endpoints (rather than the legacy global endpoint) when uploading large templates to S3 prior to deployment. This should better support US Gov regions, as well as any commercial region created after March 20, 2019 (per https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#VirtualHostingBackwardsCompatibility)
The change was successfully tested locally in us-east-1 and us-gov-west-1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.