Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont guess at mappings when values are static #3875

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3873
Description of changes:

  • When doing language extension transform don't guess at a mapping value when the FindInMap values are static

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.82%. Comparing base (8454bc9) to head (a9cc1ac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...fnlint/template/transforms/_language_extensions.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3875      +/-   ##
==========================================
- Coverage   93.83%   93.82%   -0.02%     
==========================================
  Files         365      365              
  Lines       12515    12516       +1     
  Branches     2571     2572       +1     
==========================================
- Hits        11744    11743       -1     
  Misses        426      426              
- Partials      345      347       +2     
Flag Coverage Δ
unittests 93.78% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit b1df306 into aws-cloudformation:main Dec 12, 2024
23 of 24 checks passed
@kddejong kddejong deleted the fix/issue/3873 branch December 12, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindInMap with DefaultValue vailidates unrelated Second Level Keys values against Property constraints
1 participant