chore: Fix DataStore Tests #2625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2625 +/- ##
==========================================
- Coverage 41.80% 41.79% -0.02%
==========================================
Files 903 903
Lines 28887 28887
Branches 4113 4113
==========================================
- Hits 12076 12072 -4
- Misses 15487 15489 +2
- Partials 1324 1326 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We had a few inconsistent tests that were only waiting on 1 hub event, because it was not known if 2 rapid mutations to an item would end up batched when syncing, or come 1 at a time. Rather than just waiting on 1 hub event now, some of the checks have been updated to look for the last expected item in a returned hub event.
The AndroidX Orchestrator has also been added to compartmentalize tests. running on a local machine. DeviceFarm still uses its own per class orchestrator, but this change allows all tests to pass locally while running as a full suite.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.