fix: 🐛 Updated tax base from 8% to 4.5%

awhipp · Jul 25, 2024 · eace048 · eace048
1 parent 4673bae
commit eace048
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/check_endpoints.yml b/.github/workflows/check_endpoints.yml
@@ -28,12 +28,12 @@ jobs:
 
       - name: Checking Hauling Endpoint
         run: |
-          curl -X GET "$HAULING_PROD_API?from=10000002:60003760&to=10000043:60008494&tax=0.08&minProfit=500000&minROI=0.05&maxBudget=99999999999&maxWeight=9999999&routeSafety=secure&systemSecurity=high_sec" | jq
+          curl -X GET "$HAULING_PROD_API?from=10000002:60003760&to=10000043:60008494&tax=0.045&minProfit=500000&minROI=0.05&maxBudget=99999999999&maxWeight=9999999&routeSafety=secure&systemSecurity=high_sec" | jq
 
       - name: Checking Orders Endpoint
         run: |
           curl -X GET "$ORDERS_PROD_API?itemId=33697&from=10000002:60003760&to=10000043:60008494" | jq
 
       - name: Checking Station Trading Endpoint
         run: |
-          curl -X GET "$STATION_PROD_API?station=60003760&profit=1000&tax=0.08&fee=0.03&margins=0.20,0.30&min_volume=100000&volume_filter=1" | jq
+          curl -X GET "$STATION_PROD_API?station=60003760&profit=1000&tax=0.045&fee=0.03&margins=0.20,0.30&min_volume=100000&volume_filter=1" | jq
diff --git a/api/evetrade/hauling.py b/api/evetrade/hauling.py
@@ -327,7 +327,7 @@ async def get(request) -> list:
     '''
     startTime = time.time()
     queries = request['queryStringParameters']
-    SALES_TAX = float(queries.get('tax', 0.08))
+    SALES_TAX = float(queries.get('tax', 0.045))
     MIN_PROFIT = float(queries.get('minProfit', 500000))
     MIN_ROI = float(queries.get('minROI', 0.04))
     MAX_BUDGET = float(queries.get('maxBudget', float('inf')))

diff --git a/api/evetrade/station.py b/api/evetrade/station.py
@@ -138,7 +138,7 @@ async def get(event: dict) -> list:
     queries = event['queryStringParameters']
 
     STATION = queries['station']
-    SALES_TAX = float(queries.get('tax', 0.08))
+    SALES_TAX = float(queries.get('tax', 0.045))
     BROKER_FEE = float(queries.get('fee', 0.03))
     MARGINS = list(map(float, queries.get('margins', '0.20,0.40').split(',')))
     MIN_VOLUME = int(queries.get('min_volume', 1000))

diff --git a/tests/test_gateway.py b/tests/test_gateway.py
@@ -59,7 +59,7 @@ def test_get_hauling(mock_boto_sqs) -> None:
         "queryStringParameters": {
             "from": "10000002",
             "to": "10000043",
-            "tax": 0.08,
+            "tax": 0.045,
             "minProfit": 500000,
             "minROI": 0.05,
             "routeSafety": "secure",
@@ -113,7 +113,7 @@ def test_get_hauling_nearby(mock_boto_sqs) -> None:
         "queryStringParameters": {
             "from": "10000002",
             "to": "nearby",
-            "tax": 0.08,
+            "tax": 0.045,
             "minProfit": 500000,
             "minROI": 0.05,
             "routeSafety": "secure",
@@ -165,7 +165,7 @@ def test_get_stations() -> None:
         },
         "queryStringParameters": {
             "station": "60008494",
-            "tax": "0.08",
+            "tax": "0.045",
             "fee": "0.03",
             "margins": "0.10,0.20",
             "min_volume": 1000,