Prevent double click on form submission #173
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FlavioF
added
bug
| if (isSubmitting) { | ||
| return <LoadingPage title={t('activities.form.submitting')} /> | ||
| } |
There was a problem hiding this comment.
I understand why you added a loader here.
Wouldn't this cause "blinking" on the screen?
User clicks on form submit button
-> Page abruptly changes to loading
Activity completed, now waiting for next activity
-> Page abruptly changes to loading again
Form Activity loaded
Fetching form
-> Page abruptly changes to loading again
Form fetched
I would've expected a loader on the "Submit" button (disable button, show a spinner) than showing a loader on the full page. Wdyt?
| if (isSubmitting) { | ||
| return <LoadingPage title={t('activities.form.submitting')} /> | ||
| } |
There was a problem hiding this comment.
I don't like this approach. Would prefer if we disabled the submit button on the form component itself while isSubmitting is true. I recognise this means you need to add a prop and handle this in the different form UI components but a layout-level loading page is overkill for a activity-level piece of state
Blocking, double-click on form submission and add submitting form load screen