Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uploadaction): correct fallback check for uploadPreset value #155

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(uploadaction): correct fallback check for uploadPreset value #155

merged 1 commit into from
Sep 19, 2023

Conversation

rahulkeerthi
Copy link
Contributor

Changes:

  • for the Cloudinary upload activity, we want to fall back to the extension settings value for uploadPreset if the action-level value is also not empty (i.e. not just undefined/null)

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hosted-pages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 7:54am

@rahulkeerthi rahulkeerthi added bug Something isn't working echoes/effort: XS echoes/intent: unblock Changes needed to solve a bug or unblock a customer labels Sep 19, 2023
@rahulkeerthi rahulkeerthi merged commit 853e951 into main Sep 19, 2023
6 checks passed
@rahulkeerthi rahulkeerthi deleted the ext-57-cloudinary-upload-preset-not-respecting-extension-setting branch September 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working echoes/intent: unblock Changes needed to solve a bug or unblock a customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rahulkeerthi