-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow frameworks and github.com/luno/workflow #5477
Add workflow frameworks and github.com/luno/workflow #5477
Conversation
Thank you for contributing to awesome-go. We will review your contribution as soon as possible. Make sure you add the links in the body of the pull request that are requested in the contribution guide:
|
You mentioned that you've removed: https://github.com/albrow/jobs. I think you forget to remove it as it doesn't show up as removed in your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You have added a new category, make sure you list it upon categories list.
- Make sure the category is in the right order,
Workflow
cannot come beforeJSON
. the same goes for categories list on top of the README. - You mentioned that you've removed the
https://github.com/albrow/jobs
, it doesn't seem to be removed in your changes.
Thanks @yassinebenaid, will make the appropriate changes. |
@yassinebenaid found the removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order was wrong, I've fixed it.
Thanks for valuable contribution.
Brilliant - thank you |
@@ -1492,22 +1493,17 @@ _Libraries for programming devices of the IoT._ | |||
## Job Scheduler | |||
|
|||
_Libraries for scheduling jobs._ | |||
- [Cadence-client](https://github.com/uber-go/cadence-client) - A framework for authoring workflows and activities running on top of the Cadence orchestration engine made by Uber. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--An action needed on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you give us more context on what action are you referring to!
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
https://github.com/albrow/jobs - archived
Thanks for your PR, you're awesome! 😎