Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow frameworks and github.com/luno/workflow #5477

Merged

Conversation

andrewwormald
Copy link
Contributor

@andrewwormald andrewwormald commented Nov 5, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

https://github.com/albrow/jobs - archived

Thanks for your PR, you're awesome! 😎

Copy link

github-actions bot commented Nov 5, 2024

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@yassinebenaid
Copy link
Collaborator

You mentioned that you've removed: https://github.com/albrow/jobs. I think you forget to remove it as it doesn't show up as removed in your changes.

Copy link
Collaborator

@yassinebenaid yassinebenaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You have added a new category, make sure you list it upon categories list.
  2. Make sure the category is in the right order, Workflow cannot come before JSON. the same goes for categories list on top of the README.
  3. You mentioned that you've removed the https://github.com/albrow/jobs, it doesn't seem to be removed in your changes.

@andrewwormald
Copy link
Contributor Author

  1. You have added a new category, make sure you list it upon categories list.
  2. Make sure the category is in the right order, Workflow cannot come before JSON. the same goes for categories list on top of the README.
  3. You mentioned that you've removed the https://github.com/albrow/jobs, it doesn't seem to be removed in your changes.

Thanks @yassinebenaid, will make the appropriate changes.

@andrewwormald
Copy link
Contributor Author

@yassinebenaid found the removal of https://github.com/albrow/jobs in a unpushed commit. Should be all good now.

Copy link
Collaborator

@yassinebenaid yassinebenaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order was wrong, I've fixed it.

Thanks for valuable contribution.

@yassinebenaid yassinebenaid merged commit 21bd8cf into avelino:main Nov 8, 2024
3 checks passed
@andrewwormald
Copy link
Contributor Author

Brilliant - thank you

@@ -1492,22 +1493,17 @@ _Libraries for programming devices of the IoT._
## Job Scheduler

_Libraries for scheduling jobs._
- [Cadence-client](https://github.com/uber-go/cadence-client) - A framework for authoring workflows and activities running on top of the Cadence orchestration engine made by Uber.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--An action needed on this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you give us more context on what action are you referring to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants