Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing guide: add 5-month maturity quality standard. #5473

Merged
merged 6 commits into from
Nov 2, 2024
Merged

contributing guide: add 5-month maturity quality standard. #5473

merged 6 commits into from
Nov 2, 2024

Conversation

yassinebenaid
Copy link
Collaborator

This PR adds a new rule to contributing guide:

Projects must have al least 5 months of history since their first commit

@yassinebenaid yassinebenaid linked an issue Nov 1, 2024 that may be closed by this pull request
Add a new contribution rule: Restrict projects that are unused and are not unique from being submitted #5470
Closed
Repository owner deleted a comment from github-actions bot Nov 1, 2024
phanirithvij
phanirithvij approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @avelino's input

@phanirithvij phanirithvij mentioned this pull request Nov 1, 2024
Closed
17 tasks
avelino
avelino approved these changes Nov 2, 2024
View reviewed changes
Copy link
Owner

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this rule, it will help us filter projects that have just been created and won't be maintained.

It's worth setting up an automatic check in GitHub Actions, so we don't have to do this work manually.

@avelino avelino merged commit cacc779 into avelino:main Nov 2, 2024
5 checks passed
@avelino
Copy link
Owner

avelino commented Nov 2, 2024

@yassinebenaid can you help us with this? #5473 (review)

@avelino avelino mentioned this pull request Nov 2, 2024
Closed
18 tasks
@yassinebenaid
Copy link
Collaborator Author

Sure, I'll work on a it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanirithvij phanirithvij phanirithvij approved these changes

@avelino avelino avelino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new contribution rule: Restrict projects that are unused and are not unique from being submitted
3 participants
@yassinebenaid @avelino @phanirithvij