Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dft #5374

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Added dft #5374

merged 1 commit into from
Aug 18, 2024

Conversation

abecodes
Copy link
Contributor

@abecodes abecodes commented Aug 3, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 😎

Copy link

github-actions bot commented Aug 3, 2024

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@phanirithvij
Copy link
Collaborator

phanirithvij commented Aug 13, 2024

It is too early to add this. Please resubmit in 5 months. Wait till more people use it.

@abecodes
Copy link
Contributor Author

@phanirithvij Isn't that the purpose of adding it here, so people get aware of it and start using it? The other way around would make not that much sense tbh

@phanirithvij
Copy link
Collaborator

phanirithvij commented Aug 14, 2024

The current quality standard guideline has a rule, that the project should be stable or reaching stable.
I personally don't mind using something that hasn't been used by anyone but can it be called stable?

@abecodes
Copy link
Contributor Author

Stable in the sense of the current API will not change: yes 👍
There may be one additional function to be added in the future, but otherwise that is all there is for the packages use case.

@phanirithvij phanirithvij merged commit 9a45ed0 into avelino:main Aug 18, 2024
5 checks passed
Repository owner deleted a comment from axiless0822 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants