Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-functional to list #4974

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add go-functional to list #4974

merged 1 commit into from
Aug 15, 2023

Conversation

BooleanCat
Copy link
Contributor

@BooleanCat BooleanCat commented Aug 14, 2023

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.
  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

Thanks for your PR, you're awesome! 👍

@BooleanCat
Copy link
Contributor Author

BooleanCat commented Aug 14, 2023

The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

The main branch isn't what people will use when they clone my repository, they'll use the latest tagged release. Tests are run against every commit on the repo and releases are only ever tagged from commits where tests have passed. Tests are configured to run on every PR and every commit (or merge) to the main branch.

TL;DR - I don't strictly meet the requirement as written, but I meet what I assume is the intention of the requirement: no change makes it into users hands without being gated behind automated tests.

@BooleanCat
Copy link
Contributor Author

#4976 addresses my above comment

@phanirithvij phanirithvij merged commit 8f4c258 into avelino:main Aug 15, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants