-
-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google wire library #2965
Add google wire library #2965
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body content check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code coverage is too low to meet our standard, so please increase it.
@panjf2000, I'm sorry. It is google library, and I think it is too hard to increase its coverage. I think the goal does not justify the effort. But. I start this PR only because I find in list another library with the same name wire for the same Should I close the PR? |
I appreciate your proposal but every repo in awesome-go list should be up to standard, even though it is from google. So I'm closing this PR but still, thanks for your efforts. |
It is sad. The list of libraries and tools that don't contain popular libraries because of too strict standards. https://github.com/Fs02/wire - has 25 stars, small documentation, runtime. Your strict standards don't do their job. Sometimes coverage 60% is much better than 100% on other library. |
I would also like to have the Google's wire on the list instead. It would help to get to know libraries which are used in the community most 🤔 |
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body links content check:
|
Reopen this PR to discuss whether we should make exceptions for those repositories with more stars regardless of our standards. |
@panjf2000 was discussed in this issue #1446 in short, star is not synonym of quality |
But is it obvious that Google's wire is used more often than the wire in the current list. In this case it would be more beneficial for developers to get to know the Google's wire. Especially taking into account that their approach is much different than that of Fx or Inject. I doubt that Google would write a library which does not comply with good practices |
sad @MihailsKuzmins I'm willing to talk to the package maintainers and listen to what they have to say, the communication channel via issue is open for this |
@avelino thank you for not giving up 🙏 |
Compile-time Dependency Injection for Go
Very good coverage
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR, you're awesome! 👍