Draft: Change .local domain heuristic #84
Conversation
Previous way skipped all multicast queries when unicast DNS contains local. SOA record. Change that behaviour and always request multicast name. But if local SOA is present, then make missing multicast optional and continue to DNS plugin. That would make names ending with .local to take longer resolve on unicast DNS, but should still deliver the answer.
|
Thanks for this PR! It looks pretty good! Are there any tests you can add to https://github.com/lathiat/nss-mdns/blob/master/tests/check_util.c ? |
|
Oh, this is related to old chromium bug http://crbug.com/626377 and PR #1 in this very repository. |
|
This PR is related to issues #75 and #79. It is just the first of multiple planned steps, to ensure something.local can be resolved also over (unicast) DNS in case the .local domain exists in the local server. Possible resolution might be also to disable browsing on per-network setting in avahi-daemon, as requested in issue avahi/avahi#386. Because the original implementation efectively disables all mdns addresses resolution, at least via nss plugin. If we could reuse already existing |
I have not found straight forward way to test different results of local_soa() function in unit test. Unit test would have to provide some mock function to provide answers independent on the actual network, where is the test running. Of course it is doable, I think we can make function pointer as one of parameters. |
pemensik
force-pushed
the
local-heuristic-optional
branch
from
d8b5ca3
to
f42e943
Compare
Use new enum to specify forced present or missing .local SOA record. Use from production code auto value, but use forced values from unit test. Add few different results to unit test.
pemensik
force-pushed
the
local-heuristic-optional
branch
from
f42e943
to
098bb7a
Compare
|
@agoode it would be great if the PR was backported into Fedora or a new release was made - it helps with automatic driverless device installation. |
Previous way skipped all multicast queries when unicast DNS contains local. SOA record. Change that behaviour and always request multicast name. But if local SOA is present, then make missing multicast optional and continue to DNS plugin. That would make names ending with .local to take longer resolve on unicast DNS, but should still deliver the answer.
Attempts to improve issue #75.