Make gossiper generic #1768
Open
Make gossiper generic #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
commented
Nov 13, 2024
Comment on lines
-108
to
-110
| if err := tx.VerifyAuth(ctx); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This can be moved into PreExecute within vm.Submit(...)
aaronbuchwald
commented
Nov 13, 2024
Comment on lines
-251
to
-259
| // Verify tx | ||
| if w.vm.GetVerifyAuth() { | ||
| if err := tx.VerifyAuth(ctx); err != nil { | ||
| w.logger.Error("failed to verify sig", | ||
| zap.Error(err), | ||
| ) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
check GetVerifyAuth within vm.Submit(...)
aaronbuchwald
commented
Nov 13, 2024
Comment on lines
-29
to
-34
| Top( | ||
| context.Context, | ||
| time.Duration, | ||
| func(context.Context, *Transaction) (cont bool, rest bool, err error), | ||
| ) error | ||
|
|
There was a problem hiding this comment.
Unused from this package - only used by gossiper
aaronbuchwald
commented
Nov 13, 2024
| // Copyright (C) 2024, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package chain |
There was a problem hiding this comment.
moved from chain/transaction.go
aaronbuchwald
commented
Nov 13, 2024
aaronbuchwald
commented
Nov 13, 2024
aaronbuchwald
commented
Nov 13, 2024
aaronbuchwald
commented
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the gossiper package generic and decouples it from the
*chain.Transactiontype.